feat(logging): improve event logging and add bot thinking display #1434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced Oct 2, 2025
tgasser-nv
approved these changes
Oct 3, 2025
There was a problem hiding this comment.
Looks good, just a few small comments.
BEFORE MERGING: Could you run a local integration test with all the reasoning-models we claim to support? Copy-and-paste the output into the description as a test-plan. We need to check this new approach works with production models
Pouyanpi
force-pushed
the
feat/bot-thinking-events
branch
from
8ae50ef to
98c8911
Compare
Pouyanpi
force-pushed
the
feat/runtime-event-logging
branch
from
341297f to
ead6ff7
Compare
Pouyanpi
force-pushed
the
feat/runtime-event-logging
branch
from
ead6ff7 to
bc47bea
Compare
tgasser-nv
pushed a commit
that referenced
this pull request
Oct 14, 2025
#1434) add BotThinking event support
tgasser-nv
pushed a commit
that referenced
this pull request
Oct 14, 2025
#1434) add BotThinking event support
tgasser-nv
pushed a commit
that referenced
this pull request
Oct 14, 2025
#1434) add BotThinking event support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack Info
This PR is part of a stack:
#1427 → #1431 → #1432
Description
Enhanced event logging in the runtime and callbacks to better display bot thinking events with reasoning traces. Moved event logging to occur after event generation for proper ordering, added reasoning content extraction from LLM completions, and improved console output formatting for different event types.
Changes